Added connect_mut for data changing SPI operations #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one appears to have bitrotted a little bit. Yoh, if you wanna bring it back to life we can probably get it merged. |
YohDeadfall
force-pushed
the
sql-client-by-ref
branch
3 times, most recently
from
32f0e49 to
309ab16
Compare
YohDeadfall
force-pushed
the
sql-client-by-ref
branch
from
309ab16 to
4d8aa98
Compare
|
@eeeebbbbrrrr, it's mergeable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to make the
connect_mutfunction which then can be used for mutating operations with SPI. That should be used instead of the currentSqlClientpassed by value andmutmodifier in closure arguments.That's a breaking change, so waits till
0.13.